Skip to content

Don't automatically choose MPI context in a slurm job#134

Merged
nefrathenrici merged 1 commit intomainfrom
ne/fix
Mar 26, 2026
Merged

Don't automatically choose MPI context in a slurm job#134
nefrathenrici merged 1 commit intomainfrom
ne/fix

Conversation

@nefrathenrici
Copy link
Copy Markdown
Member

Purpose

To-do

Content


  • I have read and checked the items on the review checklist.

Copy link
Copy Markdown
Member

@haakon-e haakon-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

Given the now-simplified logic, I added a suggestion to further simplify the code, but either way good to merge.

Could you also consider adding a docstring to the method to inform users of what this function does?

Comment thread src/context.jl
@nefrathenrici nefrathenrici merged commit 77a4d15 into main Mar 26, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should we remove haskey(ENV, "PMI_RANK") || haskey(ENV, "OMPI_COMM_WORLD_RANK") check in context_type?

2 participants